linux-kernel - Re: XFS Fails Quality Assurance Tests on ARM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <47277485.5090500@sandeen.net>
Date:	Tue, 30 Oct 2007 13:14:29 -0500
From:	Eric Sandeen <sandeen@...deen.net>
To:	Christoph Hellwig <hch@...radead.org>
CC:	Andi Kleen <andi@...stfloor.org>,
	David Miller <davem@...emloft.net>, byron.bbradley@...il.com,
	linux-kernel@...r.kernel.org
Subject: Re: XFS Fails Quality Assurance Tests on ARM

Christoph Hellwig wrote:
> On Tue, Oct 30, 2007 at 12:47:35AM -0500, Eric Sandeen wrote:
>> There was a patch floating around to "fix" it but it's not on-disk
>> compatible w/ x86 & friends, it just makes things consistent for arm.  I
>> think packing some of these structures would take care of it, but this
>> problem could use some attention & testing I think, it's been floating
>> around a long time.
> 
> Do you have a pointer to that patch?  Once the unaliged fields are
> identified simply using get_unaligned on them should fix this issue.
> 

http://www.spinics.net/lists/arm-kernel/msg18479.html

is the one I was thinking of, IIRC, but it just does the math a
different way so that it comes out right on ARM, and doesn't fix the
underlying problem.  I think the end result is no crashes, but a
filesystem which is broken when used on another arch.

But the problem AFAIK is that the *on-disk* structures don't match when
compiled with one ARM abi or another, I think, so get_unaligned isn't
going to help here.

-Eric
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/