linux-kernel - Re: [PATCH] several returns before unlocking in lmc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071030182832.GI32270@berith>
Date:	Tue, 30 Oct 2007 19:28:32 +0100
From:	Kristof Provost <Kristof@...vost-engineering.be>
To:	Roel Kluin <12o3l@...cali.nl>
Cc:	lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] several returns before unlocking in lmc_ioctl

On 2007-10-23 03:47:48 (+0200), Roel Kluin <12o3l@...cali.nl> wrote:
> I think we should keep the lmc_tracing. Use this patch instead.
> 
> --
>     Several returns before unlocking in lmc_ioctl
>     
>     Signed-off-by: Roel Kluin <12o3l@...cali.nl>
> ---
> diff --git a/drivers/net/wan/lmc/lmc_main.c b/drivers/net/wan/lmc/lmc_main.c
> index 5ea8772..64eb578 100644
<snip>
> @@ -229,9 +234,10 @@ int lmc_ioctl (struct net_device *dev, struct ifreq *ifr, int cmd) /*fold00*/
>          sc->lmc_xinfo.Magic1 = 0xDEADBEEF;
>  
>          if (copy_to_user(ifr->ifr_data, &sc->lmc_xinfo,
> -                         sizeof (struct lmc_xinfo)))
> -            return -EFAULT;
> -        ret = 0;
> +					sizeof(struct lmc_xinfo))) {
> +		ret = -EFAULT;
> +	else
> +		ret = 0;
I think you have an extra curly brace there. It breaks compile on my
system.

Kristof
 

Content of type "application/pgp-signature" skipped