[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <47278206.2080601@garzik.org>
Date: Tue, 30 Oct 2007 15:12:06 -0400
From: Jeff Garzik <jeff@...zik.org>
To: Linus Torvalds <torvalds@...ux-foundation.org>
CC: Mikael Pettersson <mikpe@...uu.se>,
Andrew Morton <akpm@...ux-foundation.org>,
linux-ide@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [git patches] libata fixes
Linus Torvalds wrote:
>
> On Tue, 30 Oct 2007, Jeff Garzik wrote:
>> Mikael Pettersson (2):
>> sata_promise: ASIC PRD table bug workaround, take 2
>> sata_promise: cleanups
>
> You and Mikael need to sort out the way you send/accept patches.
>
> Both of these commits had stuff like this:
>
> Signed-off-by: Mikael Pettersson <mikpe@...uu.se>
> --
> Changes since previous version:
> * use new PDC_MAX_PRD constant to initialise sg_tablesize
>
> drivers/ata/sata_promise.c | 87 ++++++++++++++++++++++++++++++++++++++++++---
> 1 files changed, 83 insertions(+), 4 deletions(-)
> Signed-off-by: Jeff Garzik <jeff@...zik.org>
>
> which seems to be because Mikael uses two dashes instead of three to
> separate his "real message" from the stuff you have.
>
> So either you need to teach Mikael to use the proper separators, or you
> need to edit these things down to be something readable instead of keeping
> the extraneous commentary around...
>
> Pulled, but I'm hoping for cleaner commit messages in the future..
Can we change git-am to accept two dashes as well as three? :)
It seems pretty common, not just with Mikael but several others who send
patches to me.
Jeff
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists