linux-kernel - Re: checkpatch bug: space between left parenthesis and asterisk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <47278BE8.6010901@oracle.com>
Date:	Tue, 30 Oct 2007 12:54:16 -0700
From:	Zach Brown <zach.brown@...cle.com>
To:	Timur Tabi <timur@...escale.com>
CC:	apw@...dowen.org, linux-kernel@...r.kernel.org
Subject: Re: checkpatch bug: space between left parenthesis and asterisk

Timur Tabi wrote:
> I'm running checkpatch.pl (dated 10/17), and it complains about this line:
> 
> crc = __be32_to_cpu(* ((__be32 *) ((void *) firmware + calc_size)));

Well, that is a bit of a stinker.  Maybe it could be reworked a little
to make it easier for humans and checkpatch to understand?

  __be32 *crazy_pointer = (void *)firmware + calc_size;
  crc = be32_to_cpu(*crazy_pointer);

(Does this need to worry about get_unaligned() at all?)

- z
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/