[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <472797FB.3050509@tiscali.nl>
Date: Tue, 30 Oct 2007 21:45:47 +0100
From: Roel Kluin <12o3l@...cali.nl>
To: Adrian Bunk <bunk@...nel.org>
CC: Andrew Morton <akpm@...ux-foundation.org>,
"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
jgarzik@...ox.com, linux-kernel@...r.kernel.org
Subject: Re: [2.6 patch] fix drivers/net/wan/lmc/ compilation
Adrian Bunk wrote:
> Documentation/SubmitChecklist, point 1:
>
> <-- snip -->
>
> ...
> CC drivers/net/wan/lmc/lmc_main.o
> /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/net/wan/lmc/lmc_main.c: In function ‘lmc_ioctl’:
> /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/net/wan/lmc/lmc_main.c:239: error: expected expression before ‘else’
> ...
> make[5]: *** [drivers/net/wan/lmc/lmc_main.o] Error 1
>
> <-- snip -->
>
> Signed-off-by: Adrian Bunk <bunk@...nel.org>
>
> ---
> d5e92a30491abf073e0a7f4d46b466c7c97f0f61
> diff --git a/drivers/net/wan/lmc/lmc_main.c b/drivers/net/wan/lmc/lmc_main.c
> index 64eb578..37c52e1 100644
> --- a/drivers/net/wan/lmc/lmc_main.c
> +++ b/drivers/net/wan/lmc/lmc_main.c
> @@ -234,7 +234,7 @@ int lmc_ioctl (struct net_device *dev, struct ifreq *ifr, int cmd) /*fold00*/
> sc->lmc_xinfo.Magic1 = 0xDEADBEEF;
>
> if (copy_to_user(ifr->ifr_data, &sc->lmc_xinfo,
> - sizeof(struct lmc_xinfo))) {
> + sizeof(struct lmc_xinfo)))
> ret = -EFAULT;
> else
> ret = 0;
>
I am sorry, my patch broke this and Kristov Provost also noticed this.
See http://lkml.org/lkml/2007/10/30/355
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists