[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20071030140124.984aba58.akpm@linux-foundation.org>
Date: Tue, 30 Oct 2007 14:01:24 -0700
From: Andrew Morton <akpm@...ux-foundation.org>
To: Tilman Schmidt <tilman@...p.cc>
Cc: linux-kernel@...r.kernel.org, gregkh@...e.de,
linux-usb-devel@...ts.sourceforge.net, hjlipp@....de,
kkeil@...e.de, i4ldeveloper@...tserv.isdn4linux.de
Subject: Re: [PATCH 1/2] usb_gigaset: suspend support [v2]
On Mon, 29 Oct 2007 22:41:30 +0100 (CET)
Tilman Schmidt <tilman@...p.cc> wrote:
> From: Tilman Schmidt <tilman@...p.cc>
>
> Add basic suspend/resume support to the usb_gigaset driver.
> (Corrected version.)
>
You're not a big fan of checkpatch, I see.
> +static int gigaset_suspend(struct usb_interface *intf, pm_message_t message)
> +{
> + struct cardstate *cs;
> + struct usb_cardstate *ucs;
> +
> + if ((cs = usb_get_intfdata(intf)) == NULL ||
> + (ucs = cs->hw.usb) == NULL) {
> + err("%s: no cardstate", __func__);
> + return -EFAULT;
> + }
Is the above reeeeeely needed? I bet it never happens.
> +static int gigaset_resume(struct usb_interface *intf)
> +{
> + struct cardstate *cs;
> + struct usb_cardstate *ucs;
> + int rc;
> +
> + if ((cs = usb_get_intfdata(intf)) == NULL ||
> + (ucs = cs->hw.usb) == NULL) {
> + err("%s: no cardstate", __func__);
> + return -EFAULT;
> + }
ditto.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists