[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20071030212313.D4CB8247F3@gemini.denx.de>
Date: Tue, 30 Oct 2007 22:23:13 +0100
From: Wolfgang Denk <wd@...x.de>
To: Stefan Roese <stefan.roese@...il.com>
cc: Josh Boyer <jwboyer@...il.com>, linuxppc-dev@...abs.org,
linux-kernel@...r.kernel.org,
Lennart Sorensen <lsorense@...lub.uwaterloo.ca>
Subject: Re: Bootup support for watchdog with short timeout (touch_nmi_watchdog()?)
Hello Stefan,
In message <200710301216.15033.stefan.roese@...il.com> you wrote:
>
> I already have it running on my system using a quick hack (see patch below) in
> include/asm-ppc/nmi.h (yes, still arch/ppc for now :-( ). But for a clean
> implementation, that has chances for upstream merge (in arch/powerpc later),
> I would really like to hear if I should move on further this way.
>
> My impression is, that changing the name from touch_nmi_watchdog() to
> something like touch_watchdog(), and therefore touching lots of files, makes
> it more unlikely that this resulting patch will get accepted. But
> implementing this bootup watchdog support in asm-ppc(asm-powerpc)/nmi.h
> header seems also not totally correct, since it's not really an NMI in this
> case.
Indeed. Using the header file <asm/nmi.h> is seriously misleading for
the PowerPC version, as is the function name touch_nmi_watchdog() -
thius has nothing to do with NMIs on PowerPC, and most probably not on
any other non-x86 architecture as well.
To make this mechanism generally usable (which is a good idea IMO) the
names should be changed to get rid of the "nmi" reference.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@...x.de
It may be that your whole purpose in life is simply to serve as a
warning to others.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists