linux-kernel - Re: checkpatch bug: space between left parenthesis and asterisk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20071030214634.GA4574@shadowen.org>
Date:	Tue, 30 Oct 2007 21:46:34 +0000
From:	Andy Whitcroft <apw@...dowen.org>
To:	Timur Tabi <timur@...escale.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: checkpatch bug: space between left parenthesis and asterisk

On Tue, Oct 30, 2007 at 02:27:13PM -0500, Timur Tabi wrote:
> I'm running checkpatch.pl (dated 10/17), and it complains about this line:
> 
> crc = __be32_to_cpu(* ((__be32 *) ((void *) firmware + calc_size)));
> 
> the message I get is:
> 
> ERROR: need space before that '*' (ctx:BxW)
> #721: FILE: arch/powerpc/sysdev/qe_lib/qe.c:527:
> +       crc = __be32_to_cpu(* ((__be32 *) ((void *) firmware + calc_size)));

Hmmm, i've looked back a couple of releases and this seems to get
reported correctly.  Removing this space is then silent.

ERROR: no space after that '*' (ctx:BxW)
#4: FILE: Z31.c:1:
+       crc = __be32_to_cpu(* ((__be32 *) ((void *) firmware + calc_size)));

What version is checkpatch reported as?  Also can I have the entire diff
hunk this is from in case its being caused by the context, though that
seems unlikely.

Thanks.

-apw
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/