lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20071030055056.GG7499@kernel.dk> Date: Tue, 30 Oct 2007 06:50:58 +0100 From: Jens Axboe <jens.axboe@...cle.com> To: Herbert Xu <herbert@...dor.apana.org.au> Cc: "David S. Miller" <davem@...emloft.net>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, Linux Crypto Mailing List <linux-crypto@...r.kernel.org>, netdev@...r.kernel.org Subject: Re: [PATCH 1/2] [CRYPTO] tcrypt: Move sg_init_table out of timing loops On Tue, Oct 30 2007, Herbert Xu wrote: > On Mon, Oct 29, 2007 at 09:16:27PM +0100, Jens Axboe wrote: > > On Fri, Oct 26 2007, Herbert Xu wrote: > > > [CRYPTO] tcrypt: Move sg_init_table out of timing loops > > > > > > This patch moves the sg_init_table out of the timing loops for hash > > > algorithms so that it doesn't impact on the speed test results. > > > > Wouldn't it be better to just make sg_init_one() call sg_init_table? > > This looks fine to me although I think it's orthogonal to the > patch you were quoting :) How so? The reason you changed it to sg_init_table() + sg_set_buf() is exactly because sg_init_one() didn't properly init the entry (as they name promised). -- Jens Axboe - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists