linux-kernel - Re: [PATCH] fix typo in per_cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071030071513.GE5361@verge.net.au>
Date:	Tue, 30 Oct 2007 16:15:13 +0900
From:	Simon Horman <horms@...ge.net.au>
To:	Luming Yu <luming.yu@...il.com>
Cc:	linux-ia64@...r.kernel.org,
	Linux Kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] fix typo in per_cpu_offset

On Tue, Oct 23, 2007 at 03:15:55PM +0800, Luming Yu wrote:
> Hello list,
> 
> there is a typo in the definition of per_cpu_offset because, for ia64,
> the __per_cpu_offset is an array.
> 
>  extern unsigned long __per_cpu_offset[NR_CPUS];
> -#define per_cpu_offset(x) (__per_cpu_offset(x))
> +#define per_cpu_offset(x) (__per_cpu_offset[x])
> 
> Thanks,
> Luming
> 
> Signed-off-by: Yu Luming <luming.yu@...el.com>

This looks correct to me, and gcc seems to agree too.

Though curiuously with my config nothing uses per_cpu_offset()
(I added a bogus call to produce an error.) Is it actually
used on ia64?

Acked-by: Simon Horman <horms@...ge.net.au>

-- 
Horms
  H: http://www.vergenet.net/~horms/
  W: http://www.valinux.co.jp/en/

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/