lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <200710310917.12832.hverkuil@xs4all.nl> Date: Wed, 31 Oct 2007 09:17:12 +0100 From: Hans Verkuil <hverkuil@...all.nl> To: David Miller <davem@...emloft.net> Cc: torvalds@...ux-foundation.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH]: exit_ivtv_i2c() cannot be __devexit On Wednesday 31 October 2007 05:23, David Miller wrote: > Please apply, thanks! > > [MEDIA] IVTV: exit_ivtv_i2c() cannot be __devexit > > It is referenced both from __devinit code (ivtv_probe) and > normal .text (ivtv_process_eeprom), and therefore cannot > be discarded via __devexit. Good catch! Signed-off-by: Hans Verkuil <hverkuil@...all.nl> Thanks, Hans > > Signed-off-by: David S. Miller <davem@...emloft.net> > --- > drivers/media/video/ivtv/ivtv-i2c.c | 2 +- > drivers/media/video/ivtv/ivtv-i2c.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/video/ivtv/ivtv-i2c.c > b/drivers/media/video/ivtv/ivtv-i2c.c index 285fca6..623eea2 100644 > --- a/drivers/media/video/ivtv/ivtv-i2c.c > +++ b/drivers/media/video/ivtv/ivtv-i2c.c > @@ -741,7 +741,7 @@ int __devinit init_ivtv_i2c(struct ivtv *itv) > return i2c_bit_add_bus(&itv->i2c_adap); > } > > -void __devexit exit_ivtv_i2c(struct ivtv *itv) > +void exit_ivtv_i2c(struct ivtv *itv) > { > IVTV_DEBUG_I2C("i2c exit\n"); > > diff --git a/drivers/media/video/ivtv/ivtv-i2c.h > b/drivers/media/video/ivtv/ivtv-i2c.h index 677c329..de6a074 100644 > --- a/drivers/media/video/ivtv/ivtv-i2c.h > +++ b/drivers/media/video/ivtv/ivtv-i2c.h > @@ -36,6 +36,6 @@ void ivtv_call_i2c_clients(struct ivtv *itv, > unsigned int cmd, void *arg); > > /* init + register i2c algo-bit adapter */ > int __devinit init_ivtv_i2c(struct ivtv *itv); > -void __devexit exit_ivtv_i2c(struct ivtv *itv); > +void exit_ivtv_i2c(struct ivtv *itv); > > #endif - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists