linux-kernel - Re: [PATCH] dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071031115308.GC27084@one.firstfloor.org>
Date:	Wed, 31 Oct 2007 12:53:08 +0100
From:	Andi Kleen <andi@...stfloor.org>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	Andi Kleen <andi@...stfloor.org>,
	Christoph Hellwig <hch@...radead.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Ingo Molnar <mingo@...e.hu>, Daniel Walker <dwalker@...sta.com>
Subject: Re: [PATCH] dump_stack on panic

I suspect most of the panics you cited are unnecessary and should
be revisited anyways. Linux should be far beyond the "we left out error
handling and put in panic instead" philosophy of classical Unix now
and those are mostly just some left overs.  But that's a different issue.

> IMHO I believe we should do the dump_stack now, and come up with another
> solution to the mount root panic.

You mean never. You want the change, you do it please properly the first
time. Doing stack dumps on no root or machine check is utterly wrong.

It is bad enough we always get them on OOM events where they are also
mostly pointless.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/