linux-kernel - Re: [PATCH] dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 31 Oct 2007 11:00:56 -0400 (EDT)
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Arjan van de Ven <arjan@...radead.org>
cc:	LKML <linux-kernel@...r.kernel.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Ingo Molnar <mingo@...e.hu>,
	Christoph Hellwig <hch@...radead.org>,
	Daniel Walker <dwalker@...sta.com>
Subject: Re: [PATCH] dump_stack on panic


--
On Wed, 31 Oct 2007, Arjan van de Ven wrote:

> On Tue, 30 Oct 2007 20:02:59 -0400
> Steven Rostedt <rostedt@...dmis.org> wrote:
>
> > Is there any reason why we don't do a dump_stack on panic?
>
>
> panic() should never be used for kernel type of bugs, that's what
> BUG_ON() is for. panic() tends to be for "your cpu melted" and "you
> don't have a root fs".. nothing else.
>
> for both of those cases, a stack trace actually hurts because it
> scrolls the useful information off the screen instead.

Then we need to go and remove all the panics that are not needed and
replace them with Bugs.

I've had too many issues in development where I hit a panic and it gives
me nothing to tell me why.

At the very least, we should have a dump_stack in areas that are usually
caused by kernel bugs. For example, killing an interrupt handler.

-- Steve

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/