linux-kernel - Re: [PATCH] mmap: restore -ENODEV on missing f

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4727D539.3080103@suse.com>
Date:	Tue, 30 Oct 2007 21:07:05 -0400
From:	Jeff Mahoney <jeffm@...e.com>
To:	Randy Dunlap <rdunlap@...otime.net>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] mmap: restore -ENODEV on missing f_op->mmap

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Randy Dunlap wrote:
> On Tue, 30 Oct 2007 15:45:56 -0700 (PDT) Linus Torvalds wrote:
> 
>>
>> On Tue, 30 Oct 2007, Jeff Mahoney wrote:
>>>  Personally, I think this is probably a case of LTP codifying existing
>>>  behavior rather than testing the for the specification. If that's the case
>>>  and nobody really cares about the change in behavior, I'm fine letting this
>>>  drop.
>> Hmm.. I think it's kind of stupid adding that special case early on, just 
>> to get one particular error case return when there are multiple possible 
>> ones. 
>>
>> I don't care deeply, but this does smell like a test issue rather than a 
>> code issue.
>>
>> Looking at that path, there are *other* things that might be worth 
>> cleaning up, but this wasn't one of them..
> 
> 
> Jeff, will you (at least) notify the LTP project of this issue and
> need for a patch?

Sure. I'll send that out tonight or tomorrow morning.

- -Jeff

- --
Jeff Mahoney
SUSE Labs
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.4-svn0 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org

iD8DBQFHJ9U5LPWxlyuTD7IRArcqAJ4hGnSf0Z67sLJJ6OU4t72VFodPnQCbBwHw
Usml2lnHxuwyXpXvjwlTbaI=
=ss6E
-----END PGP SIGNATURE-----
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/