linux-kernel - Re: [PATCH] Unexport asm/user.h and linux/user.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4728EE43.2080206@zytor.com>
Date:	Wed, 31 Oct 2007 14:06:11 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	"Kirill A. Shutemov" <k.shutemov@...il.com>
CC:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	David Woodhouse <dwmw2@...radead.org>,
	linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>
Subject: Re: [PATCH] Unexport asm/user.h and linux/user.h

Kirill A. Shutemov wrote:
> Do not export asm/user.h and linux/user.h during make headers_install.
> 
> Signed-off-by: Kirill A. Shutemov <k.shutemov@...il.com>
> Reviewed-By: David Woodhouse <dwmw2@...radead.org>
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Cc: Ingo Molnar <mingo@...hat.com>
> Cc: H. Peter Anvin <hpa@...or.com>

The version that is in there is currently broken from a user-space 
perspective (gdb expects u_ar0 to be struct user_regs_struct *, which it 
isn't for a bunch of the architectures defined); it *could* be argued 
the right thing is to fix it up since it *does* export an ABI
-- specifically, the format of a.out core dumps -- but it is probably 
easier to just axe it; userspace has had to deal with this issue on its 
own for a long time already.

As such,

Acked-by: H. Peter Anvin <hpa@...or.com>

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/