linux-kernel - Re: [PATCH 1/2] usb_gigaset: suspend support [v2]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20071101114537.0091c8d1.akpm@linux-foundation.org>
Date:	Thu, 1 Nov 2007 11:45:37 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Tilman Schmidt <tilman@...p.cc>
Cc:	linux-kernel@...r.kernel.org, gregkh@...e.de,
	linux-usb-devel@...ts.sourceforge.net, hjlipp@....de,
	kkeil@...e.de, i4ldeveloper@...tserv.isdn4linux.de,
	"Rafael J. Wysocki" <rjw@...k.pl>
Subject: Re: [PATCH 1/2] usb_gigaset: suspend support [v2]

On Thu, 01 Nov 2007 19:20:07 +0100
Tilman Schmidt <tilman@...p.cc> wrote:

> >> +static int gigaset_suspend(struct usb_interface *intf, pm_message_t message)
> >> +{
> >> +	struct cardstate *cs;
> >> +	struct usb_cardstate *ucs;
> >> +
> >> +	if ((cs = usb_get_intfdata(intf)) == NULL ||
> >> +	    (ucs = cs->hw.usb) == NULL) {
> >> +		err("%s: no cardstate", __func__);
> >> +		return -EFAULT;
> >> +	}
> > 
> > Is the above reeeeeely needed?  I bet it never happens.
> 
> I'm a great believer in defensive programming. :-)
> 
> Anyway, to be sure these checks aren't needed, I would need the
> assurance that the suspend and resume methods are serialized with
> the probe and disconnect methods. Are they?

dunno it beats me.  Not to my knowledge.  Perhaps Greg and Rafael would know?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/