linux-kernel - Re: [PATCH] [sysfs]: make readlink result shorter when the symlink and its target shared some base sysfs subdirectory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3ae72650711011159u53a48ce0ge118427c2107be01@mail.gmail.com>
Date:	Thu, 1 Nov 2007 19:59:57 +0100
From:	"Kay Sievers" <kay.sievers@...y.org>
To:	"Greg KH" <gregkh@...e.de>
Cc:	"Denis Cheng" <crquan@...il.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [sysfs]: make readlink result shorter when the symlink and its target shared some base sysfs subdirectory

On Oct 31, 2007 3:34 PM, Greg KH <gregkh@...e.de> wrote:
> On Wed, Oct 31, 2007 at 06:34:20PM +0800, Denis Cheng wrote:
> > this is especially useful after /sys/slab introduced, for example:
> >
> > $ ls -l /sys/slab/mm_struct
> > lrwxrwxrwx 1 root root 0 2007-10-31 17:40 /sys/slab/mm_struct -> :0000448
> >
> > instead of:
> >
> > $ ls -l /sys/slab/mm_struct
> > lrwxrwxrwx 1 root root 0 2007-10-31 17:40 /sys/slab/mm_struct -> ../slab/:0000448
> >
> > Signed-off-by: Denis Cheng <crquan@...il.com>
>
> As pretty as this change is, it's not really necessary, right?
>
> Is there any other place in /sys that would benefit from this?

Yeah:
  ep_81 -> ../../../../../devices/pci0000:00/0000:00:1d.0/usb2/2-0:1.0/usb_endpoint/usbdev2.1_ep81

just becomes:
  ep_81 -> usb_endpoint/usbdev1.1_ep81

which is nice. The current logic always goes back down to the root of sysfs
and moves forward to the target, which in this case prepends the pointless:
  "../../../../../devices/pci0000:00/0000:00:1d.0/usb2/2-0:1.0/" to
the target string.

Kay
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/