linux-kernel - Re: [linux-usb-devel] [PATCH 1/2] usb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 01 Nov 2007 21:17:22 +0100
From:	Tilman Schmidt <tilman@...p.cc>
To:	Oliver Neukum <oliver@...kum.org>
CC:	linux-usb-devel@...ts.sourceforge.net,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, Greg KH <gregkh@...e.de>,
	Hansjoerg Lipp <hjlipp@....de>, Karsten Keil <kkeil@...e.de>,
	i4ldeveloper@...tserv.isdn4linux.de
Subject: Re: [linux-usb-devel] [PATCH 1/2] usb_gigaset: suspend support

Am 30.10.2007 09:52 schrieb Oliver Neukum:
> Am Montag 29 Oktober 2007 schrieb Tilman Schmidt:

>> --- a/drivers/isdn/gigaset/usb-gigaset.c	2007-10-23 01:48:12.000000000 +0200
>> +++ b/drivers/isdn/gigaset/usb-gigaset.c	2007-10-24 00:47:32.000000000 +0200
>> @@ -847,6 +859,63 @@ static void gigaset_disconnect(struct us
>>  	gigaset_unassign(cs);
>>  }
>>  
>> +/* gigaset_suspend
>> + * This function is called before the USB connection is suspended or reset.
>> + */
>> +static int gigaset_suspend(struct usb_interface *intf, pm_message_t message)
>> +{
>> +	struct cardstate *cs;
>> +	struct usb_cardstate *ucs;
>> +	int rc;
>> +
>> +	if ((cs = usb_get_intfdata(intf)) == NULL ||
>> +	    (ucs = cs->hw.usb) == NULL) {
>> +		err("%s: no cardstate", __func__);
>> +		return -EFAULT;
>> +	}
>> +
>> +	//FIXME stop common module activities? ISDN_STAT_STOP? block open()?
>> +
>> +	/* stop submitting bulk URBs */
>> +	tasklet_disable(&cs->write_tasklet);
>> +
>> +	/* kill pending read URB */
>> +	usb_kill_urb(ucs->read_urb);
> 
> no pending write URB?

There shouldn't be. A read URB is always posted in case the device
sends anything, even while the device is idle, but a write URB is
only submitted if there's actual activity. But you're right, it's
safer to add a "usb_kill_urb(ucs->bulk_out_urb);" here just in case.

Thanks,
Tilman

-- 
Tilman Schmidt                          E-Mail: tilman@...p.cc
Bonn, Germany
Diese Nachricht besteht zu 100% aus wiederverwerteten Bits.
Ungeöffnet mindestens haltbar bis: (siehe Rückseite)


Download attachment "signature.asc" of type "application/pgp-signature" (254 bytes)