linux-kernel - Re: [2.6 patch] video/sis/: fix negative array index

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20071101152131.3f657cc4.akpm@linux-foundation.org>
Date:	Thu, 1 Nov 2007 15:21:31 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Adrian Bunk <bunk@...nel.org>
Cc:	adaplas@...il.com, linux-kernel@...r.kernel.org,
	Thomas Winischhofer <thomas@...ischhofer.net>
Subject: Re: [2.6 patch] video/sis/: fix negative array index

On Sat, 27 Oct 2007 16:19:46 +0200
Adrian Bunk <bunk@...nel.org> wrote:

> --- a/drivers/video/sis/sis_main.c
> +++ b/drivers/video/sis/sis_main.c
> @@ -1245,24 +1245,25 @@ sisfb_do_set_var(struct fb_var_screeninfo *var, int isactive, struct fb_info *in
>  		ivideo->sisfb_mode_idx++;
>  	}
>  
>  	if(found_mode) {
>  		ivideo->sisfb_mode_idx = sisfb_validate_mode(ivideo,
>  				ivideo->sisfb_mode_idx, ivideo->currentvbflags);
> -		ivideo->mode_no = sisbios_mode[ivideo->sisfb_mode_idx].mode_no[ivideo->mni];
>  	} else {
>  		ivideo->sisfb_mode_idx = -1;
>  	}
>  
>         	if(ivideo->sisfb_mode_idx < 0) {
>  		printk(KERN_ERR "sisfb: Mode %dx%dx%d not supported\n", var->xres,
>  		       var->yres, var->bits_per_pixel);
>  		ivideo->sisfb_mode_idx = old_mode;
>  		return -EINVAL;
>  	}
>  
> +	ivideo->mode_no = sisbios_mode[ivideo->sisfb_mode_idx].mode_no[ivideo->mni];

oic, sisfb_validate_mode() could have returned a -ve error code.

Please use the changelog to fully explain your patches.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/