linux-kernel - Re: [IRDA] IRNET: Fix build when TCGETS2 is defined.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071101223010.6780cc98@the-village.bc.nu>
Date:	Thu, 1 Nov 2007 22:30:10 +0000
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Cc:	davem@...emloft.net
Subject: Re: [IRDA] IRNET: Fix build when TCGETS2 is defined.

On Thu, 1 Nov 2007 19:59:25 GMT
Linux Kernel Mailing List <linux-kernel@...r.kernel.org> wrote:

> Gitweb:     http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=49259d34c52df6be482fefca946debe28ba9a2f6
> Commit:     49259d34c52df6be482fefca946debe28ba9a2f6
> Parent:     3b582cc14c50f71eabf1c3cada05acb8dc9f457c
> Author:     David S. Miller <davem@...set.davemloft.net>
> AuthorDate: Thu Nov 1 02:26:38 2007 -0700
> Committer:  David S. Miller <davem@...set.davemloft.net>
> CommitDate: Thu Nov 1 02:26:38 2007 -0700
> 
>     [IRDA] IRNET: Fix build when TCGETS2 is defined.
>     
>     Signed-off-by: David S. Miller <davem@...emloft.net>

NO NO NO NO NO NO NO

Line disciplines have no business touching termios ioctls. Especially
wrongly. 

Nothing anywhere in the kernel but the core ioctl code should be
processing TCGET/TCSET calls.

Just delete them. It will return -ENOIOCTLCMD and the core tty layer will
process them.

Alan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/