linux-kernel - Re: [PATCH/RFC] x86: unify Kconfig files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071101052513.GB31445@uranus.ravnborg.org>
Date:	Thu, 1 Nov 2007 06:25:13 +0100
From:	Sam Ravnborg <sam@...nborg.org>
To:	Jeremy Fitzhardinge <jeremy@...p.org>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>
Subject: Re: [PATCH/RFC] x86: unify Kconfig files

On Wed, Oct 31, 2007 at 09:08:03PM -0700, Jeremy Fitzhardinge wrote:
> Sam Ravnborg wrote:
> > It has been requested that we should let x86 behave like
> > other architectures so we at config time decide for 32 or 64 bit.
> > The challenge here is to mere the Kconfig files and I have done
> > an attempt to do so.
> >
> > +source "mm/Kconfig"
> >  
> > -config X86_VISWS_APIC
> > +config HIGHPTE
> > +	bool "Allocate 3rd-level pagetables from highmem"
> > +	depends on X86_32 && HIGHMEM4G || HIGHMEM64G
> >   
> 
> Some parens: X86_32 && (HIGHMEM4G || HIGHMEM64G)?

Yes - thanks.

This particular X86_32 dependency is for documentation only since
HIGHMEM4G and HIGHMEM64G is a X86_32 thing only.
But depite this is should be correct.
I will audit the other dependencies for the same bug.

	Sam
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/