| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Fri, 2 Nov 2007 12:30:22 -0700 From: David Brownell <david-b@...bell.net> To: Adrian Bunk <bunk@...nel.org> Cc: Randy Dunlap <randy.dunlap@...cle.com>, Toralf Förster <toralf.foerster@....de>, linux-kernel@...r.kernel.org, netdev <netdev@...r.kernel.org> Subject: Re: build #337 failed for 2.6.24-rc1-gb1d08ac In function `usbnet_set_settings': On Friday 02 November 2007, Adrian Bunk wrote: > This approach has two disadvantages: > - it's complicated No more so than the problem itself. > - the MII stuff is an implementation detail, and we shouldn't bother > the user with it (especially since we can do better) That's a Kconfig policy that's not always followed. In this case, I was getting fed up with "select". It so rarely does what it needs to do, and I've started to think it'd be better to just always avoid that fragility than battle it. > If you want to keep the #ifdef's, what's the problem with the second > patch I proposed to fix this bug? For one thing, I didn't see it until after I posted this one... other than that, the basic approach could well be fine; I didn't go through it in detail. But on the other hand, it seems that only the ASIX code will work right; the DM9601 and MCS7830 Kconfig is different/wrong. - Dave - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists