[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20071103083358.GE10760@elte.hu>
Date: Sat, 3 Nov 2007 09:33:58 +0100
From: Ingo Molnar <mingo@...e.hu>
To: Balbir Singh <balbir@...ux.vnet.ibm.com>
Cc: Peter Zijlstra <a.p.zijlstra@...llo.nl>,
Andrew Morton <akpm@...ux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Fix delay accounting regression
* Balbir Singh <balbir@...ux.vnet.ibm.com> wrote:
> On Fri, Nov 02, 2007 at 04:53:58PM +0100, Ingo Molnar wrote:
> >
> > * Balbir Singh <balbir@...ux.vnet.ibm.com> wrote:
> >
> > > Fix the delay accounting regression introduced by commit
> > > 75d4ef16a6aa84f708188bada182315f80aab6fa. rq no longer has sched_info
> > > data associated with it. task_struct sched_info structure is used by
> > > delay accounting to provide back statistics to user space.
> >
> > no, this really is broken code. sched_clock() is not a generally
> > reliable time source so at a minimum the rq->clock fix i mentioned is
> > needed. What user-space tools are utilizing delay-accounting by the way?
> > We have most of this data available under SCHEDSTATS - how about
> > consolidating CONFIG_TASK_DELAY_ACCT into CONFIG_SCHEDSTATS?
> >
> > Ingo
>
> Hi, Ingo,
>
> How about this?
thanks, applied.
Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists