linux-kernel - [PATCH] arch/ppc: Remove an unnecessary pci_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0711031613020.7633@ask.diku.dk>
Date:	Sat, 3 Nov 2007 16:14:59 +0100 (CET)
From:	Julia Lawall <julia@...u.dk>
To:	paulus@...ba.org
Cc:	linux-kernel@...r.kernel.org
Subject: [PATCH] arch/ppc: Remove an unnecessary pci_dev_put.

From: Julia Lawall <julia@...u.dk>

Remove an unnecessary pci_dev_put.  pci_dev_put is called implicitly by the
subsequent call to pci_get_device.

The problem was detected using the following semantic patch, and corrected
by hand.

@@
expression dev;
expression E;
@@

- pci_dev_put(dev)
   ... when != dev = E
- pci_get_device(...,dev)

Signed-off-by: Julia Lawall <julia@...u.dk>

---

diff -up a/arch/ppc/platforms/prep_pci.c b/arch/ppc/platforms/prep_pci.c
--- a/arch/ppc/platforms/prep_pci.c	2007-11-03 15:25:45.000000000 +0100
+++ b/arch/ppc/platforms/prep_pci.c	2007-11-03 15:25:59.000000000 +0100
@@ -1099,7 +1099,6 @@ prep_pib_init(void)
  				pci_write_config_byte(dev, 0x43, reg);
  			}
  		}
-		pci_dev_put(dev);
  	}

  	if ((dev = pci_get_device(PCI_VENDOR_ID_WINBOND,
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/