[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Pine.LNX.4.64.0711031932020.15611@blonde.wat.veritas.com>
Date: Sat, 3 Nov 2007 19:35:29 +0000 (GMT)
From: Hugh Dickins <hugh@...itas.com>
To: Christoph Lameter <clameter@....com>
cc: Linus Torvalds <torvalds@...ux-foundation.org>,
Andrew Morton <akpm@...ux-foundation.org>,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] slub: fix leakage
On Sat, 3 Nov 2007, Christoph Lameter wrote:
> On Sat, 3 Nov 2007, Hugh Dickins wrote:
> > On Sat, 3 Nov 2007, Christoph Lameter wrote:
> > > On Sat, 3 Nov 2007, Hugh Dickins wrote:
> > >
> > > > Which fixes the leakage: Objects and Partials then remain stable.
> > >
> > > Well this code is just an optimization for a rare case.
> > > Your patch may not handle the debug situation the right way.
> >
> > Oh? How?
>
> If SLAB_DEBUG is set then your patch does not do the proper checks for the
> object, tracing information is not written and the poisoning is not done.
> See alloc_debug_processing().
Yup, you're right, thanks.
I'll followup that version I CC'ed to stable,
to stop it and say you'll supply a corrected version.
Hugh
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists