linux-kernel - Re: [PATCH] Use i8253.c lock for PC speaker on MIPS, too.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.0.999.0711021940010.3342@woody.linux-foundation.org>
Date:	Fri, 2 Nov 2007 19:46:22 -0700 (PDT)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Ralf Baechle <ralf@...ux-mips.org>
cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Jay Estabrook <jay.estabrook@...com>,
	Ivan Kokshaysky <ink@...assic.park.msu.ru>,
	Paul Mackerras <paulus@...ba.org>
Subject: Re: [PATCH] Use i8253.c lock for PC speaker on MIPS, too.



On Fri, 2 Nov 2007, Ralf Baechle wrote:
>
> The Jazz machines have to use the PIT timer for dyntick and highresolution
> kernels.  This may break because currently just like i386 used to do MIPS
> uses two separate spinlocks in the actual PIT code and the PC speaker
> code.  So switch to do it the same that x86 currently does PIT locking.

Hmm. That leaves apparently just alpha/ppc/powerpc as supporting pcspkr, 
and *not* doing this. Maybe they should be forced to do the i8253 lock in 
arch code too, and expose it through <asm/i8253.h>, instead of having that 
butt-ugly #ifdef remain in the sources?

Paul, Jay, Ivan: right now drivers/input/pcspkr.c does this:

	#if defined(CONFIG_MIPS) || defined(CONFIG_X86)
	/* Use the global PIT lock ! */
	#include <asm/i8253.h>
	#else
	#include <asm/8253pit.h>
	static DEFINE_SPINLOCK(i8253_lock);
	#endif

and wouldn't it be nice if we just changed it to

	#include <asm/i8253.h>

and got rid of one totally unnecessary stupid arch difference?

		Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/