linux-kernel - Re: 2.6.24-rc1-82798a1 compile failure (x86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071104181003.GB18771@uranus.ravnborg.org>
Date:	Sun, 4 Nov 2007 19:10:03 +0100
From:	Sam Ravnborg <sam@...nborg.org>
To:	Adrian Bunk <bunk@...nel.org>
Cc:	David Miller <davem@...emloft.net>, mingo@...e.hu,
	thomas@...hlinux.org, tglx@...utronix.de,
	linux-kernel@...r.kernel.org, linux-kbuild@...r.kernel.org,
	akpm@...ux-foundation.org
Subject: Re: 2.6.24-rc1-82798a1 compile failure (x86_64)

> > If people set something like CFLAGS in their environment, they must
> > understand what that means, and it means that universally it will
> > influence your Makefile based builds.  Yes, this means all of them and
> > even potentially the kernel build.
> > 
> > I definitely think the new kbuild CFLAGS behavior is just fine.  I
> > would never ever set CFLAGS globally in my environment and expect sane
> > things to happen.
> > 
> > If people do stupid things in their environment without being willing
> > to accept all of the consequences, that isn't a reason to not provide
> > this feature in kbuild.
> > 
> > Do you even understand that taking this out of kbuild will just push
> > the problem one level of indirection away?  Say this stupid CFLAGS
> > setting creaps into someone's gcc bootstrap, and that gcc miscompiles
> > the kernel.  You will have fun debugging that too, but I'm sad to say
> > you won't be able to pass the blame to kbuild on that one 8-/
> > 
> > It's just more proof that setting CFLAGS globally in your environment
> > is just plain stupid and asking for trouble.
> > 
> > Don't do it.
> 
> I'm not seeing what's stupid about this.
> 
> I had for years CFLAGS="-O2 -mcpu=v8" set in the environment on a
> machine where I compiled virtually all software (including gcc), and 
> different similar settings on other machines, without running into any 
> problems.
> 
> I also doubt it's wanted that the kernel picks up the -I/-L/-R flags
> I have set in some environments where many libraries are installed in 
> non-standard places.

I fully agree with David that people should realize that setting some
well-known variable can affect quite a lot.
But I also see that people use this for pure userspace issues.
So I will shortly submit a patch to Linus that uses KCFLAGS &
friends and warn if a value is picked up.

	Sam
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/