linux-kernel - Re: [PATCH 5/6] drivers/video/ps3fb: fix memset size error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.62.0711051359140.28623@pademelon.sonytel.be>
Date:	Mon, 5 Nov 2007 14:00:45 +0100 (CET)
From:	Geert Uytterhoeven <Geert.Uytterhoeven@...ycom.com>
To:	stable@...nel.org
cc:	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Li Zefan <lizf@...fujitsu.com>,
	Geoff Levand <geoffrey.levand@...sony.com>
Subject: Re: [PATCH 5/6] drivers/video/ps3fb: fix memset size error

On Mon, 5 Nov 2007, Geert Uytterhoeven wrote:
> On Mon, 5 Nov 2007, Li Zefan wrote:
> > The size passing to memset is wrong.
> > 
> > Signed-off-by Li Zefan <lizf@...fujitsu.com>
> 
> Acked-by: Geert Uytterhoeven <Geert.Uytterhoeven@...ycom.com>

As this leaks 24 bytes of uninitialized stack to user space, probably this
should be applied to -stable, too?

> > ---
> >  drivers/video/ps3fb.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/drivers/video/ps3fb.c b/drivers/video/ps3fb.c
> > index b3463dd..75836aa 100644
> > --- a/drivers/video/ps3fb.c
> > +++ b/drivers/video/ps3fb.c
> > @@ -727,7 +727,7 @@ static int ps3fb_blank(int blank, struct fb_info *info)
> >  
> >  static int ps3fb_get_vblank(struct fb_vblank *vblank)
> >  {
> > -	memset(vblank, 0, sizeof(&vblank));
> > +	memset(vblank, 0, sizeof(*vblank));
> >  	vblank->flags = FB_VBLANK_HAVE_VSYNC;
> >  	return 0;
> >  }

With kind regards,
 
Geert Uytterhoeven
Software Architect

Sony Network and Software Technology Center Europe
The Corporate Village · Da Vincilaan 7-D1 · B-1935 Zaventem · Belgium
 
Phone:    +32 (0)2 700 8453	
Fax:      +32 (0)2 700 8622	
E-mail:   Geert.Uytterhoeven@...ycom.com	
Internet: http://www.sony-europe.com/
 	
Sony Network and Software Technology Center Europe	
A division of Sony Service Centre (Europe) N.V.	
Registered office: Technologielaan 7 · B-1840 Londerzeel · Belgium	
VAT BE 0413.825.160 · RPR Brussels	
Fortis Bank Zaventem · Swift GEBABEBB08A · IBAN BE39001382358619