lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 5 Nov 2007 14:56:21 +0100 From: Jesper Nilsson <jesper.nilsson@...s.com> To: Jiri Slaby <jirislaby@...il.com> Cc: Andrew Morton <akpm@...ux-foundation.org>, Mikael Starvik <mikael.starvik@...s.com>, linux-kernel@...r.kernel.org Subject: Re: [PATCH] CRIS v10 serial driver rewrite take two On Mon, Nov 05, 2007 at 02:45:31PM +0100, Jiri Slaby wrote: > On 11/05/2007 02:11 PM, Jesper Nilsson wrote: > > if (tty_hung_up_p(filp) || > > (info->flags & ASYNC_CLOSING)) { > > if (info->flags & ASYNC_CLOSING) > > You can remove this (__^) line now, the test itself is inside > wait_event_interruptible macro yet. Ah, yes, so it is. > > - interruptible_sleep_on(&info->close_wait); > > + wait_event_interruptible(info->close_wait, > > + !info->flags & ASYNC_CLOSING); > > This is still buggy, I intentionally put the parenthesis around "info->flags & > ASYNC_CLOSING" in my previous mail. This way it will ever evaluate to 0 (since > it is as same as (!info->flags) & ASYNC_CLOSING now). Of course. I thought about it, but obviously my brain used teflon-coated memory to store that information. I'll be back with yet another version. > Jiri Slaby (jirislaby@...il.com) Thanks again for you comments, /^JN - Jesper Nilsson -- Jesper Nilsson -- jesper.nilsson@...s.com - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists