[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20071105171740.GA29481@uranus.ravnborg.org>
Date: Mon, 5 Nov 2007 18:17:40 +0100
From: Sam Ravnborg <sam@...nborg.org>
To: Christoph Hellwig <hch@...radead.org>
Cc: Thomas Gleixner <tglx@...utronix.de>,
Ingo Molnar <mingo@...hat.com>,
"H. Peter Anvin" <hpa@...or.com>,
LKML <linux-kernel@...r.kernel.org>,
Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] replace "make ARCH=i386/x86_64 with make ARCH=x86"
> >
> > For now it just error out like this:
> > $ make ARCH=i386
> > Makefile:503: /home/sam/kernel/x86.git/arch/i386/Makefile: No such file or directory
> > make: *** No rule to make target `/home/sam/kernel/x86.git/arch/i386/Makefile'. Stop.
>
> Sounds fine, other architectures had that exactly same issue before. Maybe
> we can add a more useful message thouigh like
>
> $ARCH does not exist for any non-existant arch.
Like this:
$ make ARCH=foo
Makefile:201: *** "ERROR: ARCH (foo) does not exist". Stop.
Implemented by following patch.
Sam
diff --git a/Makefile b/Makefile
index cd8701e..9c46a70 100644
--- a/Makefile
+++ b/Makefile
@@ -196,6 +196,11 @@ CROSS_COMPILE ?=
UTS_MACHINE := $(ARCH)
SRCARCH := $(ARCH)
+# Sanity check the specified ARCH
+ifeq ($(wildcard $(srctree)/arch/$(SRCARCH)),)
+ $(error "ERROR: ARCH ($(SRCARCH)) does not exist")
+endif
+
KCONFIG_CONFIG ?= .config
# SHELL used by kbuild
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists