linux-kernel - Re: [PATCH 34/54] Driver Core: add kobj

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071105191705.5f2baaaa@gondolin.boeblingen.de.ibm.com>
Date:	Mon, 5 Nov 2007 19:17:05 +0100
From:	Cornelia Huck <cornelia.huck@...ibm.com>
To:	Kay Sievers <kay.sievers@...y.org>
Cc:	Greg KH <gregkh@...e.de>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 34/54] Driver Core: add kobj_attribute handling

On Mon, 05 Nov 2007 19:07:50 +0100,
Kay Sievers <kay.sievers@...y.org> wrote:

> On Mon, 2007-11-05 at 18:43 +0100, Cornelia Huck wrote:
> > On Mon, 05 Nov 2007 18:25:40 +0100,
> > Kay Sievers <kay.sievers@...y.org> wrote:
> > 
> > > > > That should usually be done by default attributes assigned to the ktype.
> > > > > Do you have a good use case, where people need to create such attributes
> > > > > individually instead?
> > > > 
> > > > The s390 code that was converted to use kobj_attributes :)
> > > > 
> > > > These look very useful, I'll go add them to the series unless Kay really
> > > > objects.
> > > 
> > > I just want to hear a good reason to create attributes individually. :)
> > > Especially in conjunction with kobject_register(), these attributes are
> > > not available at uevent time, which is really really bad.
> > > 
> > > Default attributes just work fine, and have the proper error handling
> > > built-in. Offering special functions for it, may just encourage people
> > > to continue this "broken" way of creating attributes.
> > 
> > But where should I specify those default attributes?
> > kset_create_and_register() sets the ktype to kset_ktype...
> 
> Do you need to create attributes at a kset itself, not the kobjects that
> belong to the kset?

Yes, see arch/s390/kernel/ipl.c (and I guess anything that uses
subsys_create_file() before).
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/