linux-kernel - Re: [GIT PATCH] PCI patches for 2.6.24-rc1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.0.999.0711051432531.15101@woody.linux-foundation.org>
Date:	Mon, 5 Nov 2007 14:37:31 -0800 (PST)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Greg KH <gregkh@...e.de>
cc:	"David S. Miller" <davem@...emloft.net>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, linux-pci@...ey.karlin.mff.cuni.cz,
	pcihpd-discuss@...ts.sourceforge.net
Subject: Re: [GIT PATCH] PCI patches for 2.6.24-rc1



On Mon, 5 Nov 2007, Greg KH wrote:
> > 
> > This one is bogus:
> > 
> >     PCI: Revert "PCI: disable MSI by default on systems with Serverworks HT1000 chips"
> >     
> >     This reverts commit e3008dedff4bdc96a5f67224cd3d8d12237082a0.
> >     
> >     The real bug was an INTX issue in the tg3 ethernet chip, and
> >     cured by commit c129d962a66c76964954a98b38586ada82cf9381
> >     
> >     Signed-off-by: David S. Miller <davem@...emloft.net>
> >     Acked-by: Jeff Garzik <jgarzik@...hat.com>
> >     Signed-off-by: Greg Kroah-Hartman <gregkh@...e.de>
> 
> I'll defer to David on this one, as he sent it to me.

Btw, I'd also like to take the opportunitity to ask people to always 
include the explanation of the commit when you give a commit ID.

"git revert" does that for the commit it reverts, but the (bogus) commit 
ID that was apparently added by David (c129d962a) didn't get the 
explanation for it, so now it's totally impossible to match it up with 
anything at all..

So let me one more say:

 - don't just say 

	.. was cured by commit xyz

 - but add the one-liner description of the commit, something along the 
   lines of

	.. was cured by commit xyz ("PCI: Add quirk for devices which 
        disable MSI when INTX_DISABLE is set.")

so that the commit messages are readable even outside git.

		Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/