[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <1194342222.6544.20.camel@twins>
Date: Tue, 06 Nov 2007 10:43:42 +0100
From: Peter Zijlstra <peterz@...radead.org>
To: David Brownell <david-b@...bell.net>
Cc: linux-usb-devel@...ts.sourceforge.net, Greg KH <greg@...ah.com>,
Alan Stern <stern@...land.harvard.edu>,
Oliver Neukum <oneukum@...e.de>, Ingo Molnar <mingo@...e.hu>,
Stephen Hemminger <shemminger@...ux-foundation.org>,
linux-kernel@...r.kernel.org, apw <apw@...dowen.org>
Subject: Re: [linux-usb-devel] device struct bloat
On Mon, 2007-11-05 at 17:38 -0800, David Brownell wrote:
> On Monday 05 November 2007, Greg KH wrote:
> > --- linux-2.6-2.orig/drivers/spi/spi.c
> > +++ linux-2.6-2/drivers/spi/spi.c
>
> It'd be quicker to end up in the right hands if you had
> split this big and random patch according to subsystem...
Yeah, sorry, I just started converting mindlessly and stopped once it
compiled (which explains the missing FW bits, I don't have that in my
config). Then booted and fixed up what broke, well aside from the final
lockdep issue. As I couldn't get that fixed, I never looked twice,
didn't make it a proper patch-set, nor validated the rest of the patch.
Wasn't even planning on sending it out initially.
> There's already a patch in the MM queue that removes
> the SPI-private semaphore. Except that it's missing
> the bug noted below.
Right, lack of a recent -mm made me work against mainline. I'm sure I
would've noticed otherwise :-)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists