linux-kernel - Re: [PATCH 16/31] IGET: Stop FreeVXFS from using iget() and read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20071106022505.f32b1bff.akpm@linux-foundation.org>
Date:	Tue, 6 Nov 2007 02:25:05 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	David Howells <dhowells@...hat.com>
Cc:	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH 16/31] IGET: Stop FreeVXFS from using iget() and
 read_inode() [try #5]

On Thu, 25 Oct 2007 17:35:14 +0100 David Howells <dhowells@...hat.com> wrote:

> Stop the FreeVXFS filesystem from using iget() and read_inode().  Replace
> vxfs_read_inode() with vxfs_iget(), and call that instead of iget().
> vxfs_iget() then uses iget_locked() directly and returns a proper error code
> instead of an inode in the event of an error.
> 
> vxfs_fill_super() returns any error incurred when getting the root inode
> instead of EINVAL.

alpha:

fs/freevxfs/vxfs_inode.c:298: error: conflicting types for 'vxfs_iget'
fs/freevxfs/vxfs_extern.h:61: error: previous declaration of 'vxfs_iget' was here

Not completely trivial - the ino_t -> unsigned long conversion needs to be
propagated fairly widely in there.

(when should we be using ino_t and when should we be using unsigned long,
anyway?)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/