| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <200711070957.44165.rusty@rustcorp.com.au> Date: Wed, 7 Nov 2007 09:57:43 +1100 From: Rusty Russell <rusty@...tcorp.com.au> To: Anthony Liguori <aliguori@...ibm.com> Cc: Avi Kivity <avi@...ranet.com>, virtualization@...ts.linux-foundation.org, linux-kernel@...r.kernel.org, Dor Laor <dor.laor@...ranet.com> Subject: Re: virtio config_ops refactoring On Wednesday 07 November 2007 04:48:35 Anthony Liguori wrote: > Semantically, find requires that a field have both a type and a length. > With the exception of the VIRTQUEUE field used internally by lguest, > type is always a unique identifier. Since virtqueue information is not > a required part of the config space, it seems to me that type really > should be treated as a unique identifier. Hi Anthony, Not sure I get this. It is a unique identifier. You need the length to handle unknown fields. > find_vq also is curious in that it is stateful in it's enumeration. Well, they're *all* stateful. This gives a simple method of knowing what fields the guest understands: it marks the fields as it finds them. Then it sets the status, which allows the host to know when it's completed configuration reads. I like enumerating the virtqueues: it's not necessary but it's clearer. > This adds seemingly unnecessary complexity. I'd be happy for a simpler mechanism... Cheers, Rusty. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists