linux-kernel - Re: [patch 14/23] inodes: Support generic defragmentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071107103554.GF7374@lazybastard.org>
Date:	Wed, 7 Nov 2007 11:35:55 +0100
From:	Jörn Engel <joern@...fs.org>
To:	Andreas Schwab <schwab@...e.de>
Cc:	Jörn Engel <joern@...fs.org>,
	Christoph Lameter <clameter@....com>, akpm@...ux-foundatin.org,
	linux-kernel@...r.kernel.org, linux-mm@...ck.org,
	Mel Gorman <mel@...net.ie>
Subject: Re: [patch 14/23] inodes: Support generic defragmentation

On Wed, 7 November 2007 11:35:13 +0100, Andreas Schwab wrote:
> >
> > The fact that all pointers get changed makes me a bit uneasy:
> > 	struct foo_inode v[20];
> > 	...
> > 	fs_get_inodes(..., v, ...);
> > 	...
> > 	v[0].foo_field = bar;
> > 	
> > No warning, but spectacular fireworks.
> 
> You'l get a warning that struct foo_inode * is incompatible with void **.
- 	struct foo_inode v[20];
+ 	struct foo_inode *v[20];

Looks like my example needs a patch as well.  Anyway, the function is
used in a way that makes this a non-issue.

Jörn

-- 
You cannot suppose that Moliere ever troubled himself to be original in the
matter of ideas. You cannot suppose that the stories he tells in his plays
have never been told before. They were culled, as you very well know.
-- Andre-Louis Moreau in Scarabouche
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/