linux-kernel - Re: [PATCH 1/2] libata: Support PIO polling-only hosts.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071107130940.16b5ea86@the-village.bc.nu>
Date:	Wed, 7 Nov 2007 13:09:40 +0000
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Paul Mundt <lethal@...ux-sh.org>
Cc:	Jeff Garzik <jeff@...zik.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org,
	linuxsh-dev@...ts.sourceforge.net
Subject: Re: [PATCH 1/2] libata: Support PIO polling-only hosts.

On Wed, 7 Nov 2007 17:10:52 +0900
Paul Mundt <lethal@...ux-sh.org> wrote:

> By default ata_host_activate() expects a valid IRQ in order to
> successfully register the host. This patch enables a special case
> for registering polling-only hosts that either don't have IRQs
> or have buggy IRQ generation (either in terms of handling or
> sensing), which otherwise work fine.
> 
> Hosts that want to use polling mode can simply set ATA_FLAG_PIO_POLLING
> and pass in a NULL IRQ handler or invalid (< 0) IRQ.

NAK

Zero is "no IRQ", please use that for polling not "< 0"

> + *	A NULL @irq_handler or invalid IRQ skips the IRQ registration
> + *	and expects the host to have set polling mode on the port.
> + *

There is no need to llow NULL irq_handler as a different case here. Any
caller can provide (NULL, 0). If anything you might want to warn if they
provide IRQ 0, and a handler

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/