linux-kernel - Re: [Unionfs] Re: [PATCH] IGET: Stop UnionFS from using iget() and read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 07 Nov 2007 08:31:51 -0600
From:	Paul Albrecht <albrecht@...1.com>
To:	Erez Zadok <ezk@...sunysb.edu>
Cc:	David Howells <dhowells@...hat.com>, akpm@...ux-foundation.org,
	unionfs@...esystems.org, linux-kernel@...r.kernel.org
Subject: Re: [Unionfs] Re: [PATCH] IGET: Stop UnionFS from using iget() and
	read_inode()

On Wed, 2007-11-07 at 01:44 -0500, Erez Zadok wrote:
> In message <20071106145234.4807.69325.stgit@...thog.procyon.org.uk>, David Howells writes:
> > From: David Howells <dhowells@...hat.com>
> > 
> > Stop the UnionFS filesystem from using iget() and read_inode().  Replace
> > unionfs_read_inode() with unionfs_iget(), and call that instead of iget().
> > unionfs_iget() then uses iget_locked() directly and returns a proper error code
> > instead of an inode in the event of an error.
> > 
> > unionfs_fill_super() returns any error incurred when getting the root inode
> > instead of EINVAL.
> > 
> > Signed-off-by: David Howells <dhowells@...hat.com>
> [...]
> 
> Thanks.  I tested this code and it passed all my tests.  I'll shortly submit
> a slightly revised patch which applies cleanly against the unionfs code in
> -mm.

Does your test set include readahead-list? I can't get it to work with a
union mounted filesystem without segfault'ing and kernel oops'ing.

Paul Albrecht
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/