linux-kernel - Re: [PATCH] fat: silence warning for 64KB PAGE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87prymqfwa.fsf@duaron.myhome.or.jp>
Date:	Wed, 07 Nov 2007 23:39:01 +0900
From:	OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
To:	Olof Johansson <olof@...om.net>
Cc:	torvalds@...ux-foundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fat: silence warning for 64KB PAGE_SIZE builds

Olof Johansson <olof@...om.net> writes:

> logical_sector_size can never be more than 16 bits worth, but switching
> it to an int silences gcc. It's a sanity check that can never fail with
> 64KB PAGE_SIZE but it seems like it'd still be useful for other page
> sizes, so it's worth keeping:
>
>         if (!is_power_of_2(logical_sector_size)
>             || (logical_sector_size < 512)
>             || (PAGE_CACHE_SIZE < logical_sector_size)) {
>                 if (!silent)
>                         printk(KERN_ERR "FAT: bogus logical sector size %u\n",
>                                logical_sector_size);
>                 brelse(bh);
>                 goto out_invalid;
>         }

Please use 4096 instead of allowing it, at least for now.
-- 
OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/