[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20071107160629.GA17238@uranus.ravnborg.org>
Date: Wed, 7 Nov 2007 17:06:29 +0100
From: Sam Ravnborg <sam@...nborg.org>
To: Adrian Bunk <bunk@...nel.org>
Cc: Thomas Gleixner <tglx@...utronix.de>,
Ingo Molnar <mingo@...hat.com>,
"H. Peter Anvin" <hpa@...or.com>,
LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86: unification of cfufreq/Kconfig
On Wed, Nov 07, 2007 at 08:18:01AM +0100, Adrian Bunk wrote:
> On Wed, Nov 07, 2007 at 08:06:44AM +0100, Sam Ravnborg wrote:
> > On Wed, Nov 07, 2007 at 07:02:20AM +0100, Adrian Bunk wrote:
> > > On Wed, Nov 07, 2007 at 12:01:12AM +0100, Sam Ravnborg wrote:
> > > >...
> > > > config X86_SPEEDSTEP_CENTRINO
> > > > - tristate "Intel Enhanced SpeedStep"
> > > > + tristate "Intel Enhanced SpeedStep (deprecated)"
> > > > select CPU_FREQ_TABLE
> > > > - select X86_SPEEDSTEP_CENTRINO_TABLE
> > > > + select X86_SPEEDSTEP_CENTRINO_TABLE if X86_32
> > > > + depends on X86_64 && ACPI_PROCESSOR
> > > >...
> > >
> > > No.
> > >
> > > depends on ACPI_PROCESSOR if X86_64
> >
> > Gives syntax error.
>
> That happens when you review something without trying it...
>
> depends on (ACPI_PROCESSOR || !X86_64)
Got confused by the if and did the wrong conversion.
To make it look like the other config options I will use:
depends on X86_64 || (X86_32 && ACPI_PROCESSOR)
It is longer but simpler.
Thanks,
Sam
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists