linux-kernel - Re: Use of virtio device IDs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4731F6CE.6000205@us.ibm.com>
Date:	Wed, 07 Nov 2007 11:33:02 -0600
From:	Anthony Liguori <aliguori@...ibm.com>
To:	Rusty Russell <rusty@...tcorp.com.au>
CC:	Avi Kivity <avi@...ranet.com>,
	Gregory Haskins <gregory.haskins.ml@...il.com>,
	Dor Laor <dor.laor@...ranet.com>,
	virtualization@...ts.linux-foundation.org,
	linux-kernel@...r.kernel.org
Subject: Re: Use of virtio device IDs

Rusty Russell wrote:
> On Wednesday 07 November 2007 16:40:13 Avi Kivity wrote:
>   
>> Gregory Haskins wrote:
>>     
>>>  but FWIW: This is a major motivation for the reason that the
>>> IOQ stuff I posted a while back used strings for device identification
>>> instead of a fixed length, centrally managed namespace like PCI
>>> vendor/dev-id.  Then you can just name your device something reasonably
>>> unique (e.g. "qumranet::veth", or "ibm-pvirt-clock").
>>>       
>> I dislike strings.  They make it look as if you have a nice extensible
>> interface, where in reality you have a poorly documented interface which
>> leads to poor interoperability.
>>     
>
> Yes, you end up with exactly names like "qumranet::veth" 
> and "ibm-pvirt-clock".  I would recommend looking very hard at /proc, Open 
> Firmware on a modern system, or the Xen store, to see what a lack of 
> limitation can do to you :)
>   

FWIW, I've switched to using the PCI subsystem vendor/device IDs for 
virtio which Rusty suggested.  I think this makes even more sense than 
using the main vendor/device ID since I do think that we only should use 
a single vendor/device ID for all virtio PCI devices and then 
differentiate based on the subsystem IDs.

Regards,

Anthony Liguori

>> We will support non-pci for s390, but in order to support Windows and
>> older Linux PCI is necessary.
>>     
>
> The aim is that PCI support is clean, but that we're not really tied to PCI.  
> I think we're getting closer with the recent config changes.
>
> Cheers,
> Rusty.
>   

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/