linux-kernel - Re: [patch 04/23] dentries: Extract common code to remove dentry from lru

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071107185452.GD8918@lazybastard.org>
Date:	Wed, 7 Nov 2007 19:54:53 +0100
From:	Jörn Engel <joern@...fs.org>
To:	Christoph Lameter <clameter@....com>
Cc:	Jörn Engel <joern@...fs.org>,
	Johannes Weiner <hannes-kernel@...urebad.de>,
	akpm@...ux-foundatin.org, linux-kernel@...r.kernel.org,
	linux-mm@...ck.org, Mel Gorman <mel@...net.ie>
Subject: Re: [patch 04/23] dentries: Extract common code to remove dentry from lru

On Wed, 7 November 2007 10:55:09 -0800, Christoph Lameter wrote:
> 
> From: Christoph Lameter <clameter@....com>
> Subject: dcache: use the correct variable.
> 
> We need to use "loop" instead of "dentry"
> 
> Acked-by: Joern Engel <joern@...fs.org>
> Signed-off-by: Christoph Lameter <clameter@....com>
> 
> Index: linux-2.6/fs/dcache.c
> ===================================================================
> --- linux-2.6.orig/fs/dcache.c	2007-11-07 10:26:20.000000000 -0800
> +++ linux-2.6/fs/dcache.c	2007-11-07 10:26:27.000000000 -0800
> @@ -610,7 +610,7 @@ static void shrink_dcache_for_umount_sub
>  			spin_lock(&dcache_lock);
>  			list_for_each_entry(loop, &dentry->d_subdirs,
>  					    d_u.d_child) {
> -				dentry_lru_remove(dentry);
> +				dentry_lru_remove(loop);
>  				__d_drop(loop);
>  				cond_resched_lock(&dcache_lock);
>  			}

Erm - wouldn't this break git-bisect?

Jörn

-- 
Joern's library part 5:
http://www.faqs.org/faqs/compression-faq/part2/section-9.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/