linux-kernel - Re: [patch 04/23] dentries: Extract common code to remove dentry from lru

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0711071100350.12363@schroedinger.engr.sgi.com>
Date:	Wed, 7 Nov 2007 11:00:56 -0800 (PST)
From:	Christoph Lameter <clameter@....com>
To:	Jörn Engel <joern@...fs.org>
cc:	Johannes Weiner <hannes-kernel@...urebad.de>,
	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
	linux-mm@...ck.org, Mel Gorman <mel@...net.ie>
Subject: Re: [patch 04/23] dentries: Extract common code to remove dentry
 from lru

On Wed, 7 Nov 2007, Jörn Engel wrote:

> > Acked-by: Joern Engel <joern@...fs.org>
> > Signed-off-by: Christoph Lameter <clameter@....com>
> > 
> > Index: linux-2.6/fs/dcache.c
> > ===================================================================
> > --- linux-2.6.orig/fs/dcache.c	2007-11-07 10:26:20.000000000 -0800
> > +++ linux-2.6/fs/dcache.c	2007-11-07 10:26:27.000000000 -0800
> > @@ -610,7 +610,7 @@ static void shrink_dcache_for_umount_sub
> >  			spin_lock(&dcache_lock);
> >  			list_for_each_entry(loop, &dentry->d_subdirs,
> >  					    d_u.d_child) {
> > -				dentry_lru_remove(dentry);
> > +				dentry_lru_remove(loop);
> >  				__d_drop(loop);
> >  				cond_resched_lock(&dcache_lock);
> >  			}
> 
> Erm - wouldn't this break git-bisect?

Well Andrew will merge it into the earlier patch.