linux-kernel - Re: [RFC/PATCH] AVR32: Oprofile support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071108121413.4919e4a3@siona>
Date:	Thu, 8 Nov 2007 12:14:13 +0100
From:	Haavard Skinnemoen <hskinnemoen@...el.com>
To:	Philippe Elie <phil.el@...adoo.fr>
Cc:	oprofile-list@...ts.sourceforge.net, kernel@...32linux.org,
	linux-kernel@...r.kernel.org
Subject: Re: [RFC/PATCH] AVR32: Oprofile support

On Thu, 8 Nov 2007 10:28:06 +0100
Philippe Elie <phil.el@...adoo.fr> wrote:

> On Wed, 07 Nov 2007 at 15:05 +0000, Haavard Skinnemoen wrote:
> > +	/* PCCNT */
> > +	if (ctr->enabled && (pccr & ctr->flag_mask)) {
> > +		sysreg_write(PCCNT, -ctr->count);
> > +		oprofile_add_sample(regs, PCCNT);
> > +	}
> > +	ctr++;
> > +	/* PCNT0 */
> > +	if (ctr->enabled && (pccr & ctr->flag_mask)) {
> > +		sysreg_write(PCNT0, -ctr->count);
> > +		oprofile_add_sample(regs, PCNT0);
> > +	}
> > +	ctr++;
> > +	/* PCNT1 */
> > +	if (ctr->enabled && (pccr & ctr->flag_mask)) {
> > +		sysreg_write(PCNT1, -ctr->count);
> > +		oprofile_add_sample(regs, PCNT1);
> > +	}
> 
> Why not a loop here ?

The system register is coded into the instruction as an immediate, so
it would have to be a loop with a switch in it. And with only three
counters, I thought it looked cleaner (and faster) this way.

Håvard
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/