[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20071108065421.6ec73218@poseidon.drzeus.cx>
Date: Thu, 8 Nov 2007 06:54:21 +0100
From: Pierre Ossman <drzeus-mmc@...eus.cx>
To: Roland Dreier <roland@...italvampire.org>
Cc: Romano Giannetti <romanol@...omillas.es>, Willy Tarreau <w@....eu>,
linux-kernel@...r.kernel.org, jens.axboe@...cle.com
Subject: Re: 2.6.34-rc1 eat my photo SD card :-(
On Wed, 07 Nov 2007 15:37:46 -0800
Roland Dreier <roland@...italvampire.org> wrote:
>
> mmc: Fix sg helper copy-and-paste error
>
> Commit 45711f1a ("[SG] Update drivers to use sg helpers") had the
> following bogus change in drivers/mmc/card/queue.c:
>
> > - src_buf = page_address(src->page) + src->offset;
> > + src_buf = sg_virt(dst);
>
> (Notice that "src" is converted to "dst"). Turn this "dst" back into
> the intended "src".
>
> Cc: Jens Axboe <jens.axboe@...cle.com>
> Signed-off-by: Roland Dreier <roland@...italvampire.org>
Ouch! Well that was obviously a bug. I wonder how the hell it only explodes for Romano. I've been shuffling loads of data using -rc1 without an incident.
Rgds
--
-- Pierre Ossman
Linux kernel, MMC maintainer http://www.kernel.org
PulseAudio, core developer http://pulseaudio.org
rdesktop, core developer http://www.rdesktop.org
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists