linux-kernel - Re: nozomi version 2.1c for review

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071109142500.0201fe4a@the-village.bc.nu>
Date:	Fri, 9 Nov 2007 14:25:00 +0000
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Frank Seidel <fseidel@...e.de>
Cc:	linux-kernel@...r.kernel.org, greg@...ah.com,
	p.hardwick@...ion.com, Marcel Holtmann <marcel@...tmann.org>
Subject: Re: nozomi version 2.1c for review

> and already in Gregs git repository) i resolved and removed all those
> GET_* and SET_* macros.

Oh good, that was long overdue.

> +	switch (port) {
> +	case PORT_MDM:
> +		dc->last_ier = (dc->last_ier & ~MDM_UL) | MDM_UL;
> +		break;

	The & ~xxx is unneeded if you then set it again always

Could also clean up to be

	u8 mask[NR_PORTS] = { DIAG_UGL, APP1_UL, ... }
	dc->last_ier |= mask[port];

instead of the switch - ditto disable transmit_ul etc

> +	case PORT_DIAG:
> +		dc->last_ier = (dc->last_ier & ~DIAG_UL) | DIAG_UL;
> +		break;
> +	case PORT_APP1:
> +		dc->last_ier = (dc->last_ier & ~APP1_UL) | APP1_UL;


Looking a lot better than before and with plenty of scope for more
improvement now it can be read.

Alan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/