linux-kernel - Re: [PATCH mm] unionfs: clear partial read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <200711091526.lA9FQKFe022018@agora.fsl.cs.sunysb.edu>
Date:	Fri, 9 Nov 2007 10:26:20 -0500
From:	Erez Zadok <ezk@...sunysb.edu>
To:	Hugh Dickins <hugh@...itas.com>
Cc:	Erez Zadok <ezk@...sunysb.edu>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH mm] unionfs: clear partial read 

In message <Pine.LNX.4.64.0711090728130.22720@...nde.wat.veritas.com>, Hugh Dickins writes:
> unionfs_do_readpage forgot to clear the rest of the page when vfs_read
> does not fill the page: fix that.
> 
> Signed-off-by: Hugh Dickins <hugh@...itas.com>
> ---
> 
>  fs/unionfs/mmap.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> --- 2.6.24-rc1-mm1/fs/unionfs/mmap.c	2007-11-04 13:48:02.000000000 +0000
> +++ linux/fs/unionfs/mmap.c	2007-11-06 13:51:02.000000000 +0000
> @@ -176,7 +176,8 @@ static int unionfs_do_readpage(struct fi
>  	err = vfs_read(lower_file, page_data, PAGE_CACHE_SIZE,
>  		       &lower_file->f_pos);
>  	set_fs(old_fs);
> -
> +	if (err >= 0 && err < PAGE_CACHE_SIZE)
> +		memset(page_data + err, 0, PAGE_CACHE_SIZE - err);
>  	kunmap(page);
>  
>  	if (err < 0)

Agreed.

Erez.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/