[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <200711091656.26908.ak@suse.de>
Date: Fri, 9 Nov 2007 16:56:26 +0100
From: Andi Kleen <ak@...e.de>
To: Jeremy Fitzhardinge <jeremy@...p.org>
Cc: Christoph Lameter <clameter@....com>, linux-kernel@...r.kernel.org,
linux-mm@...ck.org,
Mathieu Desnoyers <mathieu.desnoyers@...ymtl.ca>
Subject: Re: Some interesting observations when trying to optimize vmstat handling
On Friday 09 November 2007 01:19, Jeremy Fitzhardinge wrote:
> Andi Kleen wrote:
> > The only problem is that there might be some code who relies on
> > restore_flags() restoring other flags that IF, but at least for
> > interrupts and local_irq_save/restore it should be fine to change.
>
> I don't think so. We don't bother to save/restore the other flags in
> Xen paravirt and it doesn't seem to cause a problem. The semantics
> really are specific to the state of the interrupt flag.
Yes i checked the code and only case I found is actually save_flags, not
restore_flags
(and that particular case is even unnecessary)
-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists