linux-kernel - Re: dio_get_page() lockdep complaints

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071109130156.4b05a652@think.oraclecorp.com>
Date:	Fri, 9 Nov 2007 13:01:56 -0500
From:	Chris Mason <chris.mason@...cle.com>
To:	Zach Brown <zach.brown@...cle.com>
Cc:	Trond Myklebust <trond.myklebust@....uio.no>,
	Peter Zijlstra <peterz@...radead.org>,
	Jens Axboe <jens.axboe@...cle.com>,
	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	linux-aio@...ck.org
Subject: Re: dio_get_page() lockdep complaints

On Fri, 09 Nov 2007 09:48:22 -0800
Zach Brown <zach.brown@...cle.com> wrote:

> 
> >> So reiser and NFS need to be fixed.  No?
> > 
> > Actually, it is rather mmap() needs to be fixed.
> 
> Sure, I'm willing to have that demonstrated.  My point was that DIO
> getting the mmap_sem inside i_mutex is currently correct.
> 
> reiserfs, though, seems to be out on a more precarious limb ;).

reiserfs is doing tail packing during the file_release call, which has
lots of advantages for removing complexity in file_write.

Without getting into a huge patch, the best fix would just be switching
to try lock.  If the tail doesn't get packed, the world doesn't end.

-chris
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/