linux-kernel - Re: dio_get_page() lockdep complaints

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071109143554.4b3b8961@think.oraclecorp.com>
Date:	Fri, 9 Nov 2007 14:35:54 -0500
From:	Chris Mason <chris.mason@...cle.com>
To:	Zach Brown <zach.brown@...cle.com>
Cc:	Trond Myklebust <trond.myklebust@....uio.no>,
	Peter Zijlstra <peterz@...radead.org>,
	Jens Axboe <jens.axboe@...cle.com>,
	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	linux-aio@...ck.org
Subject: Re: dio_get_page() lockdep complaints

On Fri, 09 Nov 2007 11:16:53 -0800
Zach Brown <zach.brown@...cle.com> wrote:

> > Ugh, I thought the preallocation was getting freed elsewhere, but it
> > looks like I was wrong.  We can't just skip the i_mutex after all,
> > sorry.
> 
> Ah, so none of those tests at the top will stop tail packing if
> there's been pre-allocation?
> 
> Like, uh, the inode reference count test?
> 

It always drops prealloc, regardless of i_count.  One fix is to change
the prealloc routines to take/drop a reference on the inode.
preallocation is already dropped when the transaction ends, so things
would continue working.

-chris
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/